-
Notifications
You must be signed in to change notification settings - Fork 254
[UX] Add material preview #597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c45abcd
to
e61e14b
Compare
I have plans to do it including 3D models. |
I understand, thanks for explaining! I added because saves me a lot of time and the editor 4 had it. @julien-moreau what do you think about letting those previous features behind a preference flag? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand that this feature is important, I can propose to do it quickly for materials, then I'll let you add support of meshes (and more if needed like procedural textures, etc. ?)
@julien-moreau That works for me! If you are busy, you can also let me know what do you have in mind and I can try. If memory is the issue, we can create thumbnails of 512x512 size. Or a more overkill approach, we could save the thumbnails in an electron-store and load them on-the-fly based on the visibility. If the main problem is the editor hanging we could also load the thumbnails async. Or we could have both. |
Exact, what I have in mind is that we create thumbnails of 256x256 (like textures that are resized in the assets browser) and then save them to a cache. Today there is a |
That works! @julien-moreau I will have some free time today. I can draft something in this PR. Is that ok? |
5e8f0d8
to
0362381
Compare
0362381
to
40a1701
Compare
I think we can close this one |
@julien-moreau with pleasure! |
Title
Add material preview
Summary
Add material preview in the assets-browser
Changes Made
Add material thumbnail
Benefits